Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a negative test for full exit has partial withdrawal #3946

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add a negative test for full exit has partial withdrawal #3946

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8385726
Add a negative test for full exit has partial withdrawal
terencechain Sep 26, 2024
29552a7
Capitalize comment
jtraglia Sep 30, 2024
111a658
Merge branch 'dev' into full-exit-has-partial-withdrawal-test
mkalinin Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_withdrawal_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,8 @@ def test_partial_withdrawal_activation_epoch_less_than_shard_committee_period(
)


@with_electra_and_later
@spec_state_test
def test_insufficient_balance(spec, state):
rng = random.Random(1361)
state.slot += spec.config.SHARD_COMMITTEE_PERIOD * spec.SLOTS_PER_EPOCH
Expand All @@ -813,6 +815,41 @@ def test_insufficient_balance(spec, state):
success=False,
)


@with_electra_and_later
@spec_state_test
def test_full_exit_request_has_partial_withdrawal(spec, state):
rng = random.Random(1361)
# Move state forward SHARD_COMMITTEE_PERIOD epochs to allow for exit
state.slot += spec.config.SHARD_COMMITTEE_PERIOD * spec.SLOTS_PER_EPOCH

current_epoch = spec.get_current_epoch(state)
validator_index = rng.choice(spec.get_active_validator_indices(state, current_epoch))
validator_pubkey = state.validators[validator_index].pubkey
address = b"\x22" * 20
set_eth1_withdrawal_credential_with_balance(
spec, state, validator_index, address=address
)
withdrawal_request = spec.WithdrawalRequest(
source_address=address,
validator_pubkey=validator_pubkey,
amount=spec.FULL_EXIT_REQUEST_AMOUNT,
)

# Validator can only be exited if there's no pending partial withdrawals in state
state.balances[validator_index] = spec.MAX_EFFECTIVE_BALANCE_ELECTRA
state.pending_partial_withdrawals.append(
spec.PendingPartialWithdrawal(
index=validator_index,
amount=1,
withdrawable_epoch=spec.compute_activation_exit_epoch(current_epoch),
)
)

yield from run_withdrawal_request_processing(
spec, state, withdrawal_request, success=False
)

#
# Run processing
#
Expand Down