-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of features from solc 0.8.23 release #467
Conversation
Most specifically the following feature: Commandline Interface: An empty --yul-optimizations sequence can now be always provided. Fixes: ethereum#395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, but I could not make it work, even after applying the suggested change, solc is constantly hitting an assertion, and simply refuses to compile.
Are you getting this same exception with 0.8.23+ ?
@@ -80,6 +80,14 @@ def __bytes__(self) -> bytes: | |||
) | |||
else: | |||
solc_args = (self.binary, *DEFAULT_SOLC_ARGS) | |||
|
|||
solc_version = self.version() | |||
if solc_version >= Version("0.8.23"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if solc_version >= Version("0.8.23"): | |
if solc_version >= Version.parse("0.8.23"): |
Same π @danceratopz and I discussed the issue earlier and hoped he'd offer a perspective that led to a solution. If an empty |
Looking at the help output (below), it looks like the Nonetheless, thanks for taking the time to try it out @richardgreg! The unhandled exception looks to be a minor bug in solc's command-line argument parsing: ethereum/solidity#14946
|
ποΈ Description
Most specifically the following feature:
Commandline Interface: An empty --yul-optimizations sequence can now be always provided.
π Related Issues
Fixes: #395
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.