core/state, core/vm: set-based per-scope journalling #30500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
force-pushed
the
journal_changes_pt2
branch
4 times, most recently
from
08faaba
to
c3822c5
Compare
holiman
requested review from
karalabe,
rjl493456442,
MariusVanDerWijden and
lightclient
as code owners
holiman
changed the title
|
This is running on |
core/state: add handling for DiscardSnapshot core/state: use new journal core/state, genesis: fix flaw re discard/commit. In case the state is committed, the journal is reset, thus it is not correct to Discard/Revert snapshots at that point. core/state: fix nil defer in merge core/state: fix bugs in setjournal core/state: journal api changes core/state: bugfixes in sparse journal core/state: journal tests core/state: improve post-state check in journal-fuzzing test core/state: post-rebase fixups miner: remove discard-snapshot call, it's not needed since journal will be reset in Finalize core/state: fix tests core/state: lint core/state: supply origin-value when reverting storage change
holiman
force-pushed
the
journal_changes_pt2
branch
from
c3822c5
to
b37e8ff
Compare
|
Been benchmarking this, both block by block on head, aswell as sync from scratch up to around 11.5M range. Although this PR doesn't seem to do any harm, there's no tangible benefit seen. Closing this 🥹 |
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces set-based journalling, where the journalling-events are basically stored in per-scoped maps.
Whenever we enter a new call scope, we create a new scoped journal. Changes within the same scoped journal overwrite eachother. For example: if a scope updates a balance to from
6to5then4, then3, there will only be onepreimagein the journal. As opposed to the old journal (linear_journal), which would have multiple entries:[ prev: 6, prev: 5, prev:4].The linear / appending journal is wasteful on memory, and also slow on rollbacks, since each change is rolled back individually.
I'm planning to run some benchmarks to see if this amounts to any meaningful difference.