GetAccountRange
response limitHash
and responseBytes
spec adherence fix
#30508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two minor issues in
ServiceGetAccountRangeQuery
which servicesGetAccountRange
requests when peers are requesting accounts for during snap sync.The first issue is that the logic to prevent serving a hash larger than
limitHash
has an off-by-one:The Devp2p Spec defines
limitHash
as the "Account hash after which to stop serving data". Changing the conditional to>
instead of>=
allows us to serve thelimitHash
account according to the spec.The second issue this fixes is that geth currently serves above the
responseBytes
limit by the size of one account. This is because the size check currently happens after the account is appended to the response. The suggested fix is to move these conditional checks to before the account is appended to the response.