core/types: unify with NumberU64()

[zhiqiangxu]

I often see diff like this:

where the variable type is changed from *types.Block to *types.Header, but the former has the NumberU64() function, while the later doesn't.

This PR makes such diffs gone by also providing a NumberU64() function to the later.

[karalabe]

We don’t want an additional API method on the header that does not do much. The reason the block had it is because it’s cheaper to convert to uint64 than to copy the big.Int and then still convert. In the case of the header, there’s no big.Int copying happening.

…

On Wed, 25 Sep 2024 at 18:21, zhiqiangxu ***@***.***> wrote: @zhiqiangxu <https://github.com/zhiqiangxu> requested your review on: #30510 <#30510> core/types: unify with NumberU64() as a code owner. — Reply to this email directly, view it on GitHub <#30510 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7UGKWM5NCW4OL2AT54ATZYLIHRAVCNFSM6AAAAABO2ZOEKOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQYDCMJUGQZDQMA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[zhiqiangxu]

Here're my two cents:

It's just a simple getter, which can unify the way to get block number as uint64. And it also makes code shorter, which is good for reader.

[holiman]

I agree with @karalabe , but thanks for the effort