Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 400 error for fee recipient APIs #56

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

james-prysm
Copy link
Collaborator

@james-prysm james-prysm commented Feb 27, 2023

based on issue #55 it seems like it would be best to respond with a 400 error if it doesn't exist.
prysm now throws this error instead of just defaulting to the burn address.

@james-prysm james-prysm self-assigned this Feb 27, 2023
Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-prysm james-prysm merged commit d7d8326 into master Feb 27, 2023
@james-prysm james-prysm deleted the fee-recipient-error branch February 27, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants