Replace Boost_DIR with Boost_INCLUDE_DIR

[gmh5225]

No description provided.

[github-actions]

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

[r0qs]

Hi @gmh5225, could you clarify what exactly is incorrect in the current configuration? Could you provide more details? Are you encountering any specific issues with the current settings?

[gmh5225]

I found that using -DBoost_DIR actually fails to compile on Windows.

Using -DBoost_ROOT and -DBoost_INCLUDE_DIR is the more modern and recommended way since CMake 3.12+.

@r0qs

[cameel]

Just a heads up: please make sure this works also with Boost 1.67, which is the oldest version we still support. This is not covered by our CI (#15136).

[gmh5225]

The minimum Boost version required on Windows is 1.77. I have tested it, and it works. The documentation fixes are specifically for compiling on Windows.

[nikola-matic]

Just a heads up: please make sure this works also with Boost 1.67, which is the oldest version we still support. This is not covered by our CI (#15136).

The changes @gmh5225 made are Windows only, i.e. if the powershell script was run to install the dependencies, plus the minimum boost version for Windows is 1.77, so this is perfectly fine to go in.