Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix node-versions runner #2839

Merged
merged 2 commits into from
Jun 29, 2023
Merged

CI: Fix node-versions runner #2839

merged 2 commits into from
Jun 29, 2023

Conversation

jochem-brouwer
Copy link
Member

Closes #2829

Also adds wallet to the node tests.

acolytec3
acolytec3 previously approved these changes Jun 29, 2023
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'ma call this ready for review and approved. :-)

The previous failure on node 20 is a fluke. client has a race condition on one test that I haven't looked into yet that occasionally fails. Not related to node v20 or any such nonsense.

@jochem-brouwer
Copy link
Member Author

Note: the nightly node-version tests now pass, see:

https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/5405472812/jobs/9825440175

Ready for review

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2839 (9c9a6fc) into master (ecce06b) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.18% <ø> (ø)
blockchain 92.50% <ø> (ø)
client 87.08% <ø> (ø)
common 97.06% <ø> (ø)
devp2p 86.58% <ø> (ø)
ethash ∅ <ø> (∅)
evm 66.99% <ø> (ø)
rlp ?
statemanager 86.40% <ø> (ø)
trie 91.06% <ø> (+1.04%) ⬆️
tx 95.97% <ø> (ø)
util 85.93% <ø> (ø)
vm 77.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 9fbc8b0 into master Jun 29, 2023
40 of 41 checks passed
@holgerd77 holgerd77 deleted the ci-node-versions-fix branch June 29, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monorepo: Node version tests failing
3 participants