Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Prevent Address Creation for EIP-2929 Address Tracking #3122

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

holgerd77
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3122 (d366228) into master (0443f9b) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 92.27% <ø> (ø)
client 87.52% <ø> (ø)
common 98.19% <ø> (ø)
ethash ?
evm 71.93% <66.66%> (+0.05%) ⬆️
statemanager 90.30% <ø> (ø)
trie 89.76% <ø> (ø)
tx 96.36% <ø> (ø)
util 87.57% <ø> (ø)
vm 76.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side note: we can maybe further optimize by actually also dropping most addressToBytes. We can internally also just handle the BigInt instead of the Bytes. Then we can likely also change the journal to use BigInt instead of string, and then we can drop bytesToUnprefixedHex in journal.ts too 😄

@holgerd77 holgerd77 merged commit 4bd9438 into master Oct 27, 2023
43 of 44 checks passed
@holgerd77 holgerd77 deleted the evm-avoid-address-creation-2929-tracking branch October 27, 2023 18:18
@holgerd77
Copy link
Member Author

Side note: we can maybe further optimize by actually also dropping most addressToBytes. We can internally also just handle the BigInt instead of the Bytes. Then we can likely also change the journal to use BigInt instead of string, and then we can drop bytesToUnprefixedHex in journal.ts too 😄

I wonder though if we should still do any changes into the BigInt direction, if we think about going full-bytes at some point. 🤔

@jochem-brouwer
Copy link
Member

Oh right, good point, we should decide on that first (likely shift to Bytes directly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants