Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: add missing gasPrice param to readme example tx #3135

Merged
merged 2 commits into from
Nov 2, 2023
Merged

vm: add missing gasPrice param to readme example tx #3135

merged 2 commits into from
Nov 2, 2023

Conversation

gabrocheleau
Copy link
Contributor

This PR:

  • Fixes the Readme example tx that was missing a gasPrice param
  • Improves an error message that made it seem like pre-eip1559 transactions were providing an invalid maxFeePerGas param.

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Merging #3135 (53b969d) into master (c6d8b39) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 92.27% <ø> (?)
client 86.17% <ø> (-0.04%) ⬇️
common 98.19% <ø> (ø)
devp2p 86.32% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.93% <ø> (ø)
statemanager 90.13% <ø> (ø)
trie 90.01% <ø> (+0.29%) ⬆️
tx 96.36% <ø> (ø)
util 87.53% <ø> (?)
vm 76.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this now works. LGTM

@gabrocheleau gabrocheleau merged commit fbcffb8 into master Nov 2, 2023
44 checks passed
@holgerd77 holgerd77 deleted the vm/example-gasprice branch November 2, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: vm PR state: merge ready type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrocheleau @acolytec3