Blockchain: replace static constructors #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottyPoi
added
PR state: needs review
type: refactor
package: blockchain
breaking
target: master
ScottyPoi
force-pushed
the
Blockchain-static-methods
branch
from
99aa250
to
d440361
Compare
|
Is the target branch of this PR correct? |
Sure (?). Did you miss the whole switching? We are now in breaking release develop mode for |
|
I see, but is an insane amount of conflicting files, so I assumed that it was still the wrong branch. |
Ah, yeah, so we will do have to do with merge conflicts likely if we do all this broadly applying PRs with a lot of changes in many files. No way around that I guess! 🙂 |
ScottyPoi
force-pushed
the
Blockchain-static-methods
branch
from
d440361
to
47d901f
Compare
ScottyPoi
force-pushed
the
Blockchain-static-methods
branch
from
7d45bf5
to
c267641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #3487
Relates to #3489
Replaces all static
Blockchainclass methods with independently defined functions.Moves constructor functions to
packages/blockchain/src/constructors.tsBlockchain.create(...)>createBlockchain(...)Blockchain.fromBlocksData(...)> `createBlockchainFromBlocksData(...)moves helper functions to
packages/blockchain/src/helpers.tsgenGenesisStateRootgetGenesisStateRoot