common: move description string from being an object field to a comment

[scorbajio]

This change is inspired by #3448 and refactors the following files by removing any description string fields and instead including them as comments to reduce code size:

• eips.ts
• hardforks.ts

[holgerd77]

Ah, one step further please, so the v (+ the surrounding dict) should be killed completely! 🙂

[holgerd77]

Can you also please post a set of pre and post work numbers here so that we always have these comparison values in the PRs themselves? (Simply the two files sizes in KB pre/post should be enough in this case I guess)

[scorbajio]

It seems like some tests from other packages that directly access the v field are failing, will clean those up, but the refactor seems to be successful, with the following results for the following test code:

import { Chain, Common, Hardfork } from '@ethereumjs/common'

const c = new Common({ chain: Chain.Mainnet, hardfork: Hardfork.Prague })
console.log(c.chainId())

Before: 187.4kb
After: 162.0kb
Delta: -24.4kb

I wasn't able to import the EIPs dictionary since it's not being exported in the index file, although since it's being accessed indirectly by other exports, results should still include the size reduction it's gone through (although not entirely sure on this, may need confirmation).

[scorbajio]

I wasn't able to locally recreate any of the failing vm-api or test-wallet tests, so I just triggered a rerun to double check the CI results.

Update 1: The wallet tests now pass, so those failures seem to have been intermittent, but the vm-api tests still fail on CI and pass locally.

Update 2: I tracked down all failing tests but one to a reference to the v field in the vm-api tests, however one final test is now failing due to what seems like a missing account, will need additional debugging to see where this could be coming from.

[holgerd77]

Nice, cool, that we have a fix here!

Will merge.