tx/common: remove yParity from tx json interface

[jochem-brouwer]

This removes the alias yParity from the tx library, I introduced it for 7702 (thinking that we also used this on other txs - but we don't). This removes the alias, since there was (before this PR) either the value v in non-7702 txs, or yParity on 7702 txs.

Note: the tests fixed in #3498 still pass (just checked).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.38%. Comparing base (ef20930) to head (5dd80f3).
Report is 1 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
block	72.85% <ø> (?)
blockchain	84.84% <ø> (?)
common	94.10% <ø> (ø)
devp2p	0.00% <ø> (ø)
evm	68.91% <ø> (?)
genesis	0.00% <ø> (?)
statemanager	64.52% <ø> (ø)
trie	53.04% <ø> (-0.04%)	⬇️
tx	78.40% <ø> (?)
util	69.68% <ø> (ø)
vm	58.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[holgerd77]

LGTM

[ScottyPoi]

Tests fixed in #3495 now failing

Actually tests are failing

[jochem-brouwer]

Have marked to draft, did not read the spec too well, it seems for txs in RPC we should indeed have yParity. For 4844, 1559, 2930, (7702?) this field is mandatory, but these txs can optionally have a v field. Note: for Legacy txs the v field is mandatory and yParity does not seem to be an option. Source: https://ethereum.github.io/execution-apis/api-documentation/ (check eth_getTransactionByHash)

[jochem-brouwer]

I will close this PR, since this actually degrades matching the spec instead of increasing it, thanks for catching this @ScottyPoi 😄 👍