Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stream usage with async iterators & pipelines #3507

Closed
wants to merge 7 commits into from

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Jul 15, 2024

This change continues the work started in #3231 but with a different approach discussed in this article. The idea is to use async iterators and the Nodejs pipeline function to replace standard stream usage and phase out the dependency. Also see #3216 for a list of breaking changes being proposed/pursued.

@holgerd77
Copy link
Member

🙏

Thanks for trying!

Can you already say if you have a somewhat good feeling with this approach? Or is it too early too ask?

@scorbajio
Copy link
Contributor Author

🙏

Thanks for trying!

Can you already say if you have a somewhat good feeling with this approach? Or is it too early too ask?

Yes, it seems like the approach is workable for us. I've got the tests passing in the trie package, and I'll come back to clean this up today. I may need a second look at how I'm typing things, but otherwise things seems to be working.

@holgerd77
Copy link
Member

🙏
Thanks for trying!
Can you already say if you have a somewhat good feeling with this approach? Or is it too early too ask?

Yes, it seems like the approach is workable for us. I've got the tests passing in the trie package, and I'll come back to clean this up today. I may need a second look at how I'm typing things, but otherwise things seems to be working.

That would be pretty cool! 🤩

@acolytec3
Copy link
Contributor

This should be superseded by #3519. @scorbajio please reopen if you feel otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants