Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch js-sdsl to js-sdsl/orderedMap sub package #3528

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Switch js-sdsl to js-sdsl/orderedMap sub package #3528

merged 2 commits into from
Jul 22, 2024

Conversation

acolytec3
Copy link
Contributor

Fixes #3526

Reduces the statemanager package bundle by 4kb

@acolytec3 acolytec3 added dependencies Pull requests that update a dependency file package: client package: statemanager labels Jul 22, 2024
@acolytec3
Copy link
Contributor Author

Reduces the bundle size from :
image
to
image

So not a huge savings but still an improvement.

@acolytec3 acolytec3 requested a review from holgerd77 July 22, 2024 11:58
jochem-brouwer
jochem-brouwer approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

holgerd77
holgerd77 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(yeah, interesting, thought it would be more. 🤔 Wonder if it's worth to generally keep this dependency, this was a bit thought of that we would expand usage over time but at the end we ended up just only using this one single data structure)

@holgerd77 holgerd77 merged commit b543d2f into master Jul 22, 2024
34 checks passed
@jochem-brouwer jochem-brouwer deleted the js-sdsl-isolation branch July 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file package: client package: statemanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monorepo: Use Isolation Packages for js-sdsl
3 participants
@acolytec3 @holgerd77 @jochem-brouwer