Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Remove Param Topics #3532

Merged
merged 12 commits into from
Jul 23, 2024
Merged

Common: Remove Param Topics #3532

merged 12 commits into from
Jul 23, 2024

Conversation

holgerd77
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.90026% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.06%. Comparing base (fb50628) to head (4e3d0de).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
client ?
common 91.39% <97.90%> (?)
statemanager 64.52% <ø> (?)
trie 52.38% <ø> (?)
tx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer jochem-brouwer mentioned this pull request Jul 23, 2024
Merged
acolytec3
acolytec3 reviewed Jul 23, 2024
View reviewed changes
packages/common/src/common.ts Show resolved Hide resolved
packages/common/src/common.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
acolytec3
acolytec3 reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Left a couple of questions for us to confirm before we merge.

@acolytec3 acolytec3 merged commit f66a5e0 into master Jul 23, 2024
36 checks passed
@holgerd77 holgerd77 deleted the common-refactor branch July 23, 2024 17:21
@jochem-brouwer
Copy link
Member

Could the PR description be updated? This is handy for when we write the breaking release notes later 😄 👍

@holgerd77 holgerd77 changed the title Common Refactor Common: Remove Param Topics Jul 23, 2024
@holgerd77
Copy link
Member Author

@jochem-brouwer you're right, have done!

@jochem-brouwer
Copy link
Member

jochem-brouwer commented Jul 23, 2024 •
edited
Loading

The description is still empty for me though?

EDIT: nvm, you edited the title 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
breaking package: block package: blockchain package: common package: evm package: statemanager package: tx package: vm PR state: merge ready PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerd77 @jochem-brouwer @acolytec3