Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateManager: Do not throw calling getContractStorage on non-existing accounts #3536

Merged
merged 8 commits into from
Aug 14, 2024
Merged

StateManager: Do not throw calling getContractStorage on non-existing accounts #3536

merged 8 commits into from
Aug 14, 2024

Conversation

jochem-brouwer
Copy link
Member

Closes #3479

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.28%. Comparing base (fb50628) to head (07b3b8a).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.56% <ø> (?)
client ?
genesis 0.00% <ø> (?)
tx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3
Copy link
Contributor

This looks good to me. Should we add a check to test the result here?

@jochem-brouwer
Copy link
Member Author

I've added a test! Side-note: I did not have to edit a test, so we did not directly test "getContractStorage throws when called on non-existing account" in the past 🤔

@holgerd77
Copy link
Member

What is the status of this PR?

@jochem-brouwer
Copy link
Member Author

Ready for review!

acolytec3
acolytec3 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 6d187eb into master Aug 14, 2024
34 checks passed
@acolytec3 acolytec3 deleted the get-contract-storage-no-error-non-existing branch August 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikhai56 Mikhai56 Mikhai56 approved these changes

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
breaking package: statemanager PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make getContractStorage not throw if the account does not exist
4 participants
@jochem-brouwer @acolytec3 @holgerd77 @Mikhai56