Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linting #3539

Merged
merged 16 commits into from
Jul 25, 2024
Merged

Update linting #3539

merged 16 commits into from
Jul 25, 2024

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Jul 25, 2024 •
edited
Loading

This PR updates Eslint to v8.57 (last legacy version) and Prettier to 3.3.3.

  • Updates eslint to use top level tsconfig.lint.json so that examples are included in linting in all packages
  • Disables no-console and no-unused-vars rules in the examples
  • Cleans up obsolete lint configs in client
  • Removes various odd rules in place in specific packages
  • Fix all the lint issues

@acolytec3 acolytec3 added package: monorepo dependencies Pull requests that update a dependency file labels Jul 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 532 lines in your changes missing coverage. Please review.

Project coverage is 11.08%. Comparing base (fb50628) to head (36975a7).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
client 0.00% <0.00%> (ø)
tx 78.64% <ø> (+0.20%) ⬆️
vm 58.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

gabrocheleau
gabrocheleau previously approved these changes Jul 25, 2024
View reviewed changes
@gabrocheleau gabrocheleau self-requested a review July 25, 2024 14:11
gabrocheleau
gabrocheleau reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, can be approved and merged once addressed/replied

@gabrocheleau gabrocheleau merged commit 23d796d into master Jul 25, 2024
34 checks passed
@holgerd77 holgerd77 deleted the update-linting branch July 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 left review comments

@gabrocheleau gabrocheleau gabrocheleau approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file package: monorepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acolytec3 @holgerd77 @gabrocheleau