Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: rename constructor createBlock #3549

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Block: rename constructor createBlock #3549

merged 6 commits into from
Jul 31, 2024

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented Jul 27, 2024 •
edited
Loading

Followup to work on #3487 and #3489
Conform to naming conventions from #3524 review

block/src/constructors.ts
Renames createBlockFromBlockData > createBlock

  • deletes unused block/test/util.ts
  • renames blockchain/test helper function createBlock > createBlockFromParent
  • renames client/test helper function createBlock > createBlockFromParent

acolytec3
acolytec3 previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes

@acolytec3 acolytec3 merged commit 05ecf69 into master Jul 31, 2024
34 checks passed
@acolytec3 acolytec3 deleted the createblock branch July 31, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
breaking package: block PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottyPoi @acolytec3 @holgerd77