Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: extract static Header constructors #3550

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Block: extract static Header constructors #3550

merged 7 commits into from
Jul 30, 2024

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented Jul 27, 2024 •
edited by scorbajio
Loading

Continues work on #3487

Extract Header static constructors into block/src/constructors.ts

BlockHeader.fromHeaderData > createBlockHeader
BlockHeader.fromRLPSerializedHeader > createHeaderFromRLP
BlockHeader.fromValuesArray > createHeaderFromValuesArray

acolytec3
acolytec3 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit def477a into master Jul 30, 2024
34 checks passed
@acolytec3 acolytec3 deleted the header-constructors branch July 30, 2024 18:47
@ScottyPoi ScottyPoi mentioned this pull request Aug 5, 2024
Merged
@scorbajio scorbajio mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
breaking package: block PR state: needs review target: master Work to be done towards master branch type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @acolytec3