-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof function util helpers refactor #3551
Conversation
Using a minimal code path for the
Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. Some comments need cleanup and I think we can remove that fromProof
function entirely.
Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
…ereumjs/ethereumjs-monorepo into proof-function-util-helpers-refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@scorbajio Nice, looks super clean now! 😄 Results are also meaningful (so the -18KB), since this already helps the Block package upwards, and there reduction on this level definitely already counts in! 👍 |
This change is an alternative approach to the work started in #3538. It looks into refactoring the trie class to remove proof functionality from the main class and move them into standalone functions in order to improve tree shaking for the trie package and decrease bundle size.