-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EOF container validation script #3553
Conversation
It seems like it should work but when I try and run a process from within Java I never get any output from the subprocess. Is there a way to force flushes? My fuzzer hangs reading from the stream. Here's the equivelant Java code starting the process.
|
Could you retry with my latest commit? Otherwise I might have to figure out how to setup the Java process so I can test it myself 😅 |
No dice. I think readline package may be the issue. Java processes are just pipes, there is no higher level TTY interactions. Something like this needs to work:
and output |
This latest push could fix it? |
That works. I'll post some findings over at ipsilon/eof#146 (comment) in a bit. |
Cool, thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! We should consider rewording our Trying to read out of bounds
error to be more descriptive in a future EOF related PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, nice! 🎉❤️ Love this! 😃
From my side we could merge too (won’t do myself).
This PR adds a CLI to enable EOF container checks via the command line, see ipsilon/eof#146
Additionally, this exports
EOFContainer
andvalidateEOF
from EVM to expose this externally.Please do not merge until we get a 👍 that this works with the fuzzer.
Usage:
Ensure all libraries are build, cd into the monorepo and then
npm i
.Now
cd ./packages/evm
and thentsx ./scripts/eofContainerValidator.ts
. The file will read hex strings from the stdin and will either output OK if the container is valid, orerr: <REASON>
if there is a validation error.