Proof function renaming #3557
Merged
Proof function renaming #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
approved these changes
Aug 5, 2024
holgerd77
reviewed
Aug 6, 2024
| @@ -667,7 +669,7 @@ export class DefaultStateManager implements StateManagerInterface { | |||
| const trie = this._getStorageTrie(address) | |||
| trie.root(hexToBytes(storageHash)) | |||
| for (let i = 0; i < storageProof.length; i++) { | |||
| await updateFromProof( | |||
| await updateTrieFromMerkleProof( | |||
There was a problem hiding this comment.
Ah, especially this one I can understand a lot better just from reading it, now seeing it in the code base! 👍
|
Nice, thanks for adressing so quickly! 👍 🙂 Also great that the Verkle proof methods are already renamed along! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to provide more detail in the naming of the now standalone proof functions in the Verkle and Merkle datastructures:
The following functions have been renamed in Merkle-Land:
createProof->createMerkleProofupdateFromProof->updateTrieFromMerkleProofverifyProof->verifyMerkleProofThe following functions have been renamed in the still experimental and under development Verkle-Land:
createProof->createVerkleProofverifyProof->verifyVerkleProofThe statemanager wrapper function
verifyProofremains unchanged since keeping it general will allow for a Merkle or Verkle backend.