statemanager: re architect shallow copy to improve tree shaking #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
reviewed
Aug 15, 2024
| import { modifyAccountFields } from './util.js' | ||
|
|
||
| import { CODEHASH_PREFIX, Caches, type DefaultStateManagerOpts } from './index.js' |
There was a problem hiding this comment.
👀
Ah, ok, now I get it.
So seems my observation was correct (?).
Cool, great dive and find! 🎉 🙂
holgerd77
reviewed
Aug 15, 2024
| code: codeCacheOpts, | ||
| storage: storageCacheOpts, | ||
| }), | ||
| caches: this._caches?.shallowCopy(downlevelCaches), |
There was a problem hiding this comment.
🤯
Ugh. That's really a brilliant separation!
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures shallowCopy method of the DefaultStateManager. This improves bundle size significantly (tested with the
statemanager/examples/basicUsage.tsfile :Before the change
After the change
The improvement comes from the removal of the
Cachesclass dependency from the shallowCopy method.