Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: update default vm sm to simple state manager #3604

Closed
wants to merge 1 commit into from

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Aug 18, 2024

Preliminary attempt at addressing #3573

@holgerd77
Copy link
Member

I also addressed this within #3601, but with a different approach. I gave this a deeper look on Saturday and I think the change I proposed in #3573 does not make sense, since we do loose something with the switch (aka: too much) with the proper state root calculation in runBlock() (also for block builder and (partly) even runTx()) then just be faked.

So I honestly think this is a dead end, sorry for the not fully thought through pointer. Will close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants