-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: add getBlobsV1 to the client to support CL blob import #3711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong support for the API since we need to bring bandwidth requirements of a running a node down 😄
Two comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
The spec says:
It does however not look like we SSZ-encode the blob? I think this is mandatory here? (per spec) |
this the blobs generated/provided in tx are already in ssz encoded format which is just 131072 bytes, we don't have to do anything here |
1 similar comment
this the blobs generated/provided in tx are already in ssz encoded format which is just 131072 bytes, we don't have to do anything here |
Ok, I was not aware that the blobs were already SSZ-encoded (do not see this in EIP-4844), but if that's the case that's great, otherwise we implicitly have to take in the SSZ dependency (which we will have to do at some point when we switch to SSZ from RLP in general) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ref:
engine_getBlobsV1
ethereum/execution-apis#559TODO: add to spec test