Vaibhav/certora[L-01]/pla 723 remove split logic #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongyun-ko
reviewed
Sep 12, 2024
| /// @return toTnft the payout to the T-NFT holder | ||
| /// @return toBnft the payout to the B-NFT holder | ||
| /// @return toTreasury the payout to the Treasury | ||
| function getRewardsPayouts( |
There was a problem hiding this comment.
we wont need getRewardsPayouts at all? looking at the implementation haha
seongyun-ko
reviewed
Sep 12, 2024
vvalecha519
changed the title
vvalecha519
changed the title
Roy-Certora
reviewed
Nov 4, 2024
src/EtherFiNode.sol
Outdated
| @@ -277,52 +277,35 @@ contract EtherFiNode is IEtherFiNode, IERC1271 { | |||
| mgr.completeQueuedWithdrawals(withdrawals, tokens, middlewareTimesIndexes, receiveAsTokens); | |||
| } | |||
|
|
|||
| /// @dev transfer funds from the withdrawal safe to the 4 associated parties (bNFT, tNFT, treasury, nodeOperator) | |||
| /// @dev transfer funds from the withdrawal safe to the 4 associated parties (bNFT, tNFT) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.
For a timely review/response, please avoid force-pushing additional
commits if your PR already received reviews or comments.
Before submitting a Pull Request, please ensure you've done the following:
What type of PR is this? (check all applicable)
What part of our tech stack does this PR improve? (check all applicable)
Description
Related Tickets & Documents
For pull requests that relate or close an issue, please include them
below. We like to follow Github's guidance on linking issues to pull requests.
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes.
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?