Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquifier: pricing of stETH via CurvePool & fixed rate fee #188

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

seongyun-ko
Copy link
Contributor

@seongyun-ko seongyun-ko commented Oct 16, 2024

Context

The arbitrageurs are exploiting ether.fi's fast withdrawal processing to redeem their stETH faster.

  • some bugs

What this PR is about

  • use CurvePool to price the stETH
  • apply the fied deposit fee rate
  • enable partial redemption of stETH
  • EigenLayer's queued withdrawal struct was refactored from this to this. Then, EL team has migrated manually through it. Now, our old mapping keeping the old versions of withdrawalRoots does not work anymore. so I am removing that sanity check to process the completed withdrawals.

@jtfirek
Copy link
Contributor

jtfirek commented Oct 16, 2024

Our FE currently displays a hard coded 1 to 1 exchange rate for stETH -> eETH. We could transition to using quoteByMarketValue to get the rate, but this value won't be accurate if the fee has been applied.
This pr includes a function our FE can query to display the proper rate to our users:
#189

jtfirek
jtfirek previously approved these changes Oct 17, 2024
@shivam-ef shivam-ef self-requested a review October 21, 2024 09:25
Copy link

@shivam-ef shivam-ef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seongyun-ko seongyun-ko merged commit 1b0cb93 into master Oct 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants