Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the app so that it works with Docker #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zulhfreelancer
Copy link

Hi,

I'm currently using this project for my private blockchain setup. This is great project and here is my contribution to make this project better. 🙂

Looking forward to contribute more!

@flefevre
Copy link

flefevre commented May 3, 2018

That's song good.
It is definitively a good option to have dooker configuration for this project.
Any idea when it will be merged?

@flefevre
Copy link

flefevre commented May 4, 2018

Perhaps for READM.md, we should write something like

docker build . -t etherparty/explorer
docker run --name etherparty_explorer --rm -it -p 8000:8000 etherparty/explorer:latest

And i have a question, on the code
var host = window.location.hostname;

no other way to do it?

Thanks for comments

"prestart": "npm install",
"start": "http-server ./app -a localhost -p 8000 -c-1",

"start": "http-server ./app -a 0.0.0.0 -p 8000 -c-1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants