fix: save tags when using chunk/stream #4920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinconic
reviewed
Dec 4, 2024
| @@ -56,7 +56,7 @@ func (s *Service) chunkUploadStreamHandler(w http.ResponseWriter, r *http.Reques | |||
| } | |||
|
|
|||
| // if tag not specified use direct upload | |||
| putter, err := s.newStamperPutter(r.Context(), putterOptions{ | |||
| putter, err := s.newStamperPutter(context.Background(), putterOptions{ | |||
There was a problem hiding this comment.
why is context.Background() better here?
There was a problem hiding this comment.
probably because the go routine below handles the websocket connection but since this function returns, the context is canceled.
martinconic
approved these changes
Dec 9, 2024
istae
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Do not use HTTP request context so that tags will be saved when
putter.Doneis called after the HTTP connection is upgraded to websocket.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
closes #4858
Screenshots (if appropriate):