Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fork tracking & canonical chain selection #120

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Improve fork tracking & canonical chain selection #120

merged 2 commits into from
Sep 9, 2024

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Aug 28, 2024 •
edited
Loading

Improve fork tracking:

  • add fork ids to block received log entries for easier debugging
  • various other fixes for small bugs I've detected while running the current peerdas forkparty locally :)

Improved canonical chain selection:

  • increase number of aggregated epoch votes for minimal preset (last 2 epochs for mainnet, last 5 epochs for minimal)

@pk910 pk910 requested a review from skylenet August 28, 2024 15:19
@pk910 pk910 marked this pull request as ready for review August 28, 2024 15:19
@pk910 pk910 marked this pull request as draft August 28, 2024 15:23
@pk910 pk910 marked this pull request as ready for review August 28, 2024 21:02
@pk910 pk910 changed the title Improve fork tracking Improve fork tracking & canonical chain selection Aug 28, 2024
@pk910
Copy link
Member Author

pk910 commented Aug 28, 2024

should fix the bug reported by @MariusVanDerWijden on discord:
image

@parithosh parithosh added the build-docker-image Automatically build docker image for PR branch label Sep 5, 2024
@pk910 pk910 removed the build-docker-image Automatically build docker image for PR branch label Sep 9, 2024
@pk910 pk910 merged commit d549280 into master Sep 9, 2024
3 checks passed
@pk910 pk910 deleted the pk910/fork-detection-fixes branch September 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylenet skylenet skylenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pk910 @skylenet @parithosh