Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution layer clients page #76

Merged
merged 11 commits into from
Jul 16, 2024
Merged

execution layer clients page #76

merged 11 commits into from
Jul 16, 2024

Conversation

skylenet
Copy link
Member

@skylenet skylenet commented Jul 11, 2024 •
edited
Loading

Similar to the consensus layer client page.

This one has a bit more special treatments because not all clients implement admin_peers the same way.

Some caveats:

  • Nethermind and Besu don't have information if a peer is in/outbound. (field .network.inbound doesn't exist)
  • Nethermind always displays more peers, even though they're not compatible with the network (crawlers?).

Menu:
image

Page:
image

pk910
pk910 requested changes Jul 11, 2024
View reviewed changes
indexer/execution_client.go Outdated Show resolved Hide resolved
rpc/executionapi.go Show resolved Hide resolved
handlers/pageData.go Outdated Show resolved Hide resolved
@skylenet skylenet marked this pull request as ready for review July 15, 2024 13:39
@skylenet skylenet merged commit abd6f6f into master Jul 16, 2024
3 checks passed
@pk910 pk910 deleted the skylenet/el-vis branch August 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk910 pk910 pk910 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skylenet @pk910