Skip to content

Commit

Permalink
fix: set MEV image to 0.26.0 and complain if capella is zero with MEV…
Browse files Browse the repository at this point in the history
… set to full (#261)
  • Loading branch information
h4ck3rk3y committed Oct 5, 2023
1 parent cfca6d1 commit 9dfc4de
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 9 deletions.
7 changes: 1 addition & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ workflows:
- reth-all
- teku-all
- nimbus_mev
- complex_mev

build:
when: << pipeline.parameters.should-enable-build-workflow >>
Expand Down Expand Up @@ -241,9 +242,3 @@ workflows:
branches:
ignore:
- main

- complex_mev:
filters:
branches:
ignore:
- main
6 changes: 4 additions & 2 deletions .circleci/tests/mev.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{
"mev_type": "full",
"mev_params": {
"launch_custom_flood": true
"launch_custom_flood": true,
"mev_relay_image": "flashbots/mev-boost-relay:0.27"
},
"network_params": {
"seconds_per_slot": 3
"seconds_per_slot": 3,
"capella_fork_epoch": 0
}
}
14 changes: 13 additions & 1 deletion src/package_io/parse_input.star
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ DEFAULT_CL_IMAGES = {
"lodestar": "chainsafe/lodestar:latest",
}

MEV_BOOST_RELAY_DEFAULT_IMAGE = "flashbots/mev-boost-relay:0.26"

NETHERMIND_NODE_NAME = "nethermind"
NIMBUS_NODE_NAME = "nimbus"
Expand Down Expand Up @@ -82,6 +83,17 @@ def parse_input(plan, input_args):
result.get("mev_type"),
)

if (
result.get("mev_type") == "full"
and result["network_params"]["capella_fork_epoch"] == 0
and result["mev_params"]["mev_relay_image"] == MEV_BOOST_RELAY_DEFAULT_IMAGE
):
fail(
"The default MEV image {0} requires a non-zero value for capella fork epoch set via network_params.capella_fork_epoch".format(
MEV_BOOST_RELAY_DEFAULT_IMAGE
)
)

result["tx_spammer_params"] = get_default_tx_spammer_params()

return struct(
Expand Down Expand Up @@ -373,7 +385,7 @@ def default_participant():

def get_default_mev_params():
return {
"mev_relay_image": "flashbots/mev-boost-relay:latest",
"mev_relay_image": MEV_BOOST_RELAY_DEFAULT_IMAGE,
# TODO replace with flashbots/builder when they publish an arm64 image as mentioned in flashbots/builder#105
"mev_builder_image": "ethpandaops/flashbots-builder:main",
"mev_boost_image": "flashbots/mev-boost",
Expand Down

0 comments on commit 9dfc4de

Please sign in to comment.