feat: allow more detailed additional test configurations in assertoor_params #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasbusa
approved these changes
Feb 22, 2024
barnabasbusa
pushed a commit
that referenced
this pull request
Mar 8, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](1.4.0...2.0.0) (2024-03-08) ### ⚠ BREAKING CHANGES * participant_network & rename participant fields. ([#508](#508)) * add node selectors features ([#491](#491)) ### Features * add keymanager to all validator processes ([#502](#502)) ([836eda4](836eda4)) * add nimbus-eth1 ([#496](#496)) ([d599729](d599729)) * add node selectors features ([#491](#491)) ([316d42f](316d42f)) * allow more detailed additional test configurations in assertoor_params ([#498](#498)) ([fe2de7e](fe2de7e)) * enable api in assertoor config ([#495](#495)) ([9ceae9c](9ceae9c)) * enable dencun-genesis ([#500](#500)) ([beb764f](beb764f)) * make snapshot url configurable ([#507](#507)) ([6fa0475](6fa0475)) * parameterize mev-boost args ([#400](#400)) ([e48483a](e48483a)) * separate validator clients from CL clients ([#497](#497)) ([90da2c3](90da2c3)) ### Bug Fixes * fix end index in validator ranges file ([#509](#509)) ([da55be8](da55be8)) * lh vc flag logic ([#506](#506)) ([bc5e725](bc5e725)) * nimbus-eth1 advertise proper extip ([#501](#501)) ([1d5a779](1d5a779)) * README global node selector ([#504](#504)) ([f9343a2](f9343a2)) * use the cl as the default validator image if none are defined ([#503](#503)) ([181dd04](181dd04)) ### Code Refactoring * participant_network & rename participant fields. ([#508](#508)) ([fab341b](fab341b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability do use complex objects as test configs that are passed through to the assertoor config in json format.
It allows defining assertoor tests like this via the kurtosis params:
The old way to specify the link to the test only is still supported:
Effectively both formats can be used.
The downstream implementation is unfortunately not super nice 😅
It embeds the test configs as json objects within the yaml configuration.
This works fine as yaml inherits the json syntax.