Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sentry): Fetch beacon committees just before epoch transition #292

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix(sentry): Fetch beacon committees just before epoch transition #292

merged 2 commits into from
Apr 2, 2024

Conversation

samcm
Copy link
Member

@samcm samcm commented Apr 2, 2024

Fixes #288

@samcm samcm requested a review from Savid as a code owner April 2, 2024 02:48
Savid
Savid reviewed Apr 2, 2024
View reviewed changes
pkg/sentry/ethereum/services/duties.go
m.log.
WithField("current_epoch", epoch.Number()).
WithField("next_epoch", epoch.Number()+1).
Debug("Fetching beacon committees for next epoch")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be after the sleep?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah nice

@samcm samcm merged commit b1096c1 into master Apr 2, 2024
3 checks passed
@samcm samcm deleted the feat/beacon-committee-fix branch April 2, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Savid Savid Savid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple sets of beacon committee data for the same epoch from sentries
2 participants
@samcm @Savid