Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kalibr_bagcreater can now handle short filenames. #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pkok
Copy link

@pkok pkok commented Sep 3, 2014

Previously, filenames had to be at least 10 character, without filetype
extension. When a filename was shorter, an empty string would be passed
to int(), which results in a ValueError. With this version, when an
empty string is encountered, secs is set to 0.

Patrick de Kok added 5 commits September 3, 2014 11:47
The installation tutorial instructs to install Eigen3.  A standard
Ubuntu installation has no FindEigen.cmake, but only FindEigen3.cmake.
Therefore, I instructed CMake to require Eigen3 instead of Eigen.
Previously, filenames had to be at least 10 character, without filetype
extension.  When a filename was shorter, an empty string would be passed
to int(), which results in a ValueError.  With this version, when an
empty string is encountered, secs is set to 0.
When the sensor_msgs/Image is converted to its numpy `ndarray`
representation, it sometimes has the shape `(n, m, 1)`.  This gives an
error even though it is a `sensor_msgs::image_encodings::MONO8`.

The underlying algorithm only supports 2D arrays, and the images were
stored as 3D objects.  Error:

```
TypeError: Conversion is only valid for arrays with 1 or 2
dimensions. Argument has 3 dimensions
```

Transforming the image with a reshape if and only if it has a dimension
of lenght 1 solves this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant