Install space compatibility #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... since I have no idea how to fix them.
This also fixes a compiler warning about misleading indentation.
|
Can one of the admins verify this patch? |
goldbattle
added
enhancement
|
Hi, there are quite a few merge conflicts since the changes to make Kalibr python3 compatible. Do you have time to resolve these? I think many would appreciate install space compatibility so they can build in a ROS 2 workspace. |
|
Hey, I unfortunately don't have time to work on this currently. Maybe in a few weeks. If someone wants to take this up in the meantime, feel free :) |
|
Great. No rush, I will leave this open until someone picks it up down the line, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that kalibr has been used so far only in the catkin devel space, since many of the sub-packages contain no
install()commands or even wrong / obviously untested ones. However, install spaces are used in many contexts (e.g. binary deployment) and next-gen build systems like colcon (for ROS 2) do not support devel spaces anymore, so it is quite desirable to support installation.This PR adds
install()commands when required. It also fixes some unit tests that weren't compiling for me usingcolcon.