allow string imports outside of packages #736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow string imports outside of packages
|
IMO this will not be a popular use case, using strings instead of objects is a rather exotic and rare practice.. |
nightblure
reviewed
Nov 13, 2024
| @@ -5034,7 +5034,7 @@ def _resolve_calling_module(): | |||
|
|
|||
| def _resolve_calling_package_name(): | |||
| module = _resolve_calling_module() | |||
| return module.__package__ | |||
| return getattr(module, "__package__", None) | |||
There was a problem hiding this comment.
It seems like it would be a good idea to write tests or add test cases for clients using this _resolve_calling_package_name function
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Currently, string imports are not possible outside of packages.
Minimal reproducible example
The following code snippet executed from a script or Jupyter notebook cell raises an
AttributeError: 'NoneType' object has no attribute '__package__'The trace back reveals that the exception is thrown in
src/dependency_injector/providers.pyx in dependency_injector.providers._resolve_calling_package_name().Proposal for solution
In case the module in
dependency_injector.providers._resolve_calling_package_nameisNone, the package should also beNone. The subsequent call toimportlib.import_modulewill handle the situation properly.