Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add CI to test bpftrace #274

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ScriptSathi
Copy link

Description

This PR is base on the requested feature to add bpftrace GitHub actions.

Fixes # (issue) : github.com//issues/228

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ScriptSathi
Copy link
Author

ScriptSathi commented Apr 10, 2024

Several problems remain with the draft.

  • I use apt install bpftrace to install bpftrace. Problem is, on ubuntu the package is not up-to-date. So next step will be to clone bpftrace and install it. But the downside will be the image will be incredibly heavy, and this test will take ages to perform ...
  • I need to fix the error [error] [agent.cpp:105] Unable to initialize shared memory: No such file or directory when using the script inside Docker. I still don't know why this happened

@ScriptSathi ScriptSathi force-pushed the master branch 4 times, most recently from 2a0107f to fdd250d Compare April 19, 2024 14:12
@ScriptSathi ScriptSathi force-pushed the master branch 3 times, most recently from 2078845 to ed055b0 Compare April 19, 2024 15:08
@yunwei37 yunwei37 reopened this Aug 19, 2024
@ScriptSathi
Copy link
Author

If you want to work on this later on, you have to notice two things :

  • To test bpftrace you would like to build bpftrace from source inside the GitHub action to use the latest version, which is not trivial and may slow down a lot the running task.
  • GitHub does not yet have Ubuntu 24 available for actions, so if you want to use the built-in package, you have to test bpftime on an older kernel or old bpftrace package. If breaking change occurs, you won't know

@yunwei37
Copy link
Member

Thanks @ScriptSathi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants