Fix bug with GDAC data source and BGC dataset #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for: - deep copy (new instance with same parameters and cleared search) - shallow copy (new instance with same parameters and search results if any)
- fix bug raised when dealing with a STATION_PARAMETER index having an empty string
Re-designed how we compute the data mode of a parameter
fix compute to handle a collection of profiles (presumably with STATION_PARAMETERS and PARAMETER_DATA_MODE) or a collection of points (presumably without STATION_PARAMETERS and PARAMETER_DATA_MODE)
gmaze
added
invalid
❌ 174 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ftp fsspec is not accepting timeout=0 anymore ValueError: Non-blocking socket (timeout=0) is not supported
gmaze
commented
Dec 12, 2024
| """ | ||
| idx = copy.copy(indexfs) if isinstance(indexfs, ArgoIndex) else ArgoIndex() | ||
| idx = indexfs.copy(deep=True) if isinstance(indexfs, ArgoIndex) else ArgoIndex() |
There was a problem hiding this comment.
Here we have a new method copy for the ArgoIndex
gmaze
commented
Dec 12, 2024
| def split(self): | ||
| def compute(self, indexfs: Union[None, ArgoIndex]) -> xr.Dataset: | ||
| """Compute <PARAM>_DATA_MODE variables""" | ||
| if "STATION_PARAMETERS" in self._obj and "PARAMETER_DATA_MODE" in self._obj: |
There was a problem hiding this comment.
I did not spot this subtility before
gmaze
commented
Dec 12, 2024
| @@ -177,6 +177,8 @@ def __init__(self, mode: str = "", src: str = "", ds: str = "", **fetcher_kwargs | |||
| raise OptionValueError( | |||
| "The 'argovis' data source fetching is only available in 'standard' user mode" | |||
| ) | |||
| if self._src == "gdac" and "bgc" in self._dataset_id: | |||
There was a problem hiding this comment.
I dont remember why this was removed
gmaze
commented
Dec 12, 2024
| @@ -352,24 +354,48 @@ def split_data_mode(ds: xr.Dataset) -> xr.Dataset: | |||
| ------- | |||
| :class:`xr.Dataset` | |||
| """ | |||
| if ds.argo._type != "profile": | |||
There was a problem hiding this comment.
Raise an error to avoid passing through for the wrong reasons and not detecting it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data mode splitting method was found to provide erroneous results due to unexpected results from xarray dropna
The
ds.argo.datamode.splitmethod now use a clean ufunc method to properly extract parameter data mode