Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix warning for setup.cfg in humble #5

Merged

Conversation

v-nojiri7841-esol
Copy link
Contributor

@v-nojiri7841-esol v-nojiri7841-esol commented May 17, 2023

Description

Humble環境でビルドする時に出力される、PythonライブラリのWarningを解消します。

colcon内部で呼び出されるsetuptoolsのバージョンアップにより、setup.cfgで使われる設定値の名前のセパレータは"-"ではなく"_"を使うべきとのWarningが追加されました。setup.cfgの該当箇所を修正し、Warningが出力されないようにします。

Related links

Tests performed

colconのビルドが正常に完了し、以下のWarningが出力されないこと。

/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead
  warnings.warn(

以下のWarningについては、ament_cmake, colconのIssue(ament_cmake issue:382, colcon issue:454)にて結論が出ていないことから、修正を見送っております。

/usr/lib/python3/dist-packages/setuptools/command/easy_install.py:158: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(

修正により、install/audio_driverの配下にコピーされるファイルの違いがないことも確認済です。
修正前後でどちらも以下の出力となります。

install/audio_driverに対するtreeコマンドのログ。

se-osaka-dev34@c4f71e2738dd:~/autoware/install/audio_driver$ tree
.
|-- lib
|   |-- audio_driver
|   |   `-- audio_driver
|   `-- python3.10
|       `-- site-packages
|           `-- audio-driver.egg-link
`-- share
    |-- ament_index
    |   `-- resource_index
    |       `-- packages
    |           `-- audio_driver
    |-- audio_driver
    |   |-- hook
    |   |   |-- ament_prefix_path.dsv
    |   |   |-- ament_prefix_path.ps1
    |   |   |-- ament_prefix_path.sh
    |   |   |-- pythonpath.dsv
    |   |   |-- pythonpath.ps1
    |   |   `-- pythonpath.sh
    |   |-- launch
    |   |   `-- audio_driver.launch.xml
    |   |-- package.bash
    |   |-- package.dsv
    |   |-- package.ps1
    |   |-- package.sh
    |   |-- package.xml
    |   `-- package.zsh
    `-- colcon-core
        `-- packages
            `-- audio_driver

13 directories, 17 files

Notes for reviewers

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: v-nojiri7841-esol <v-nojiri7841@esol.co.jp>
Copy link

@m-iwashita-esol m-iwashita-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当該ディレクトリ下での"-"置き換え漏れがない事を確認しました

setup.cfg Show resolved Hide resolved
@yn-mrse yn-mrse merged commit ca95790 into eve-autonomy:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants