Skip to content

Commit

Permalink
Merge pull request #939 from eventflow/prepare-new-release
Browse files Browse the repository at this point in the history
Prepare v1 beta release
  • Loading branch information
rasmus authored Mar 13, 2022
2 parents 53de4be + 1aab01c commit 519746a
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 18 deletions.
18 changes: 12 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ jobs:

- uses: actions/checkout@v2

- name: Setup .NET Core 2.1.x
uses: actions/setup-dotnet@v1
with:
dotnet-version: "2.1.x"

- name: Setup .NET Core 3.1.x
uses: actions/setup-dotnet@v1
with:
Expand All @@ -86,7 +81,18 @@ jobs:
run: dotnet tool install -g --version 0.12.24-beta Bake

- name: Run Bake
run: bake run --build-version 1.0.$GITHUB_RUN_NUMBER
run: |
declare -i REVISION
REVISION=5000+$GITHUB_RUN_NUMBER
bake run --build-version 1.0.$REVISION
- name: Upload NuGet packages
uses: actions/upload-artifact@v2
if: success() || failure()
with:
name: packages
path: "**/*nupkg"
if-no-files-found: error

- name: Upload test results
uses: actions/upload-artifact@v2
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ jobs:

- uses: actions/checkout@v2

- name: Setup .NET Core 2.1.x
uses: actions/setup-dotnet@v1
with:
dotnet-version: "2.1.x"

- name: Setup .NET Core 3.1.x
uses: actions/setup-dotnet@v1
with:
Expand All @@ -86,7 +81,10 @@ jobs:
run: dotnet tool install -g --version 0.12.24-beta Bake

- name: Run Bake
run: bake-it/bake run --convention=Release --build-version 1.0.$GITHUB_RUN_NUMBER --destination="nuget>github,nuget,release>github"
run: |
declare -i REVISION
REVISION=5000+$GITHUB_RUN_NUMBER
bake run --convention=Release --build-version 1.0.$REVISION --destination="nuget>github,nuget,release>github"
- name: Upload test results
uses: actions/upload-artifact@v2
Expand Down
12 changes: 7 additions & 5 deletions MIGRATION_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,13 @@ public API surface.
Here is the general motivation for introducing breaking changes to EventFlow.

- The initial version of EventFlow had its own IoC and logger implementation,
but with the introduction of standardized `Microsoft.Extensions` packages,
many of these custom made implementations can be removed
- Focus on LTS versions of .NET (Core) and removing support .NET Framework.
but with the introduction of the standardized `Microsoft.Extensions` packages,
EventFlow's custom implementations are removed
- Focus on LTS versions of .NET (Core) and remove support .NET Framework as many
of the new C# language features are not available here
- Fix misssssspelled API
- Add obviously missing async/await on critical methods
- Remove non-async methods wrapper methods
- Remove non-async methods wrapper methods related to the bundled `AsyncHelper`

## Notable new features in 1.x

Expand All @@ -39,7 +40,8 @@ that wasn't possible to add before as introducing them would cause breaking chan
```

If the connection string is not known at initialization, provide your own instance
of the `IMsSqlConfiguration` which now has a new method.
of the `IMsSqlConfiguration` which now has a new method that allows reading connection
strings at runtime.

```csharp
Task<string> GetConnectionStringAsync(
Expand Down
2 changes: 1 addition & 1 deletion RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ https://github.com/eventflow/EventFlow/blob/develop-v1/MIGRATION_GUIDE.md
- `MsSqlReadModelVersionColumn`
* Breaking: Methods on `IMsSqlDatabaseMigrator` and `ISqlDatabaseMigrator` have been
made async and have an extra `CancellationToken` argument
* Breaking: Remove support for .NET Framework and consolidate on .NET Core LTS versions
* Breaking: Remove support for .NET Framework and consolidate on .NET (Core) LTS versions
* Breaking: Replace internal in-memory caching with `Microsoft.Extensions.Caching.Memory`
* Breaking: Removed `IAmAsyncReadModelFor` and made `IAmReadModelFor` async
* Breaking: Removed `EventFlow.Core.AsyncHelper` as well as all async wrapper methods
Expand Down
1 change: 1 addition & 0 deletions Source/Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@

<ItemGroup>
<None Include="$(MSBuildProjectDirectory)\..\..\icon-128.png" Pack="true" PackagePath="\"/>
<None Include="$(MSBuildProjectDirectory)\..\..\README.md" Pack="true" PackagePath="\"/>
</ItemGroup>
</Project>

0 comments on commit 519746a

Please sign in to comment.