Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup files for e2e tests #534

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ishabaral
Copy link

Added setup files for e2e testing utilizing Playwright and Cucumber.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Test only

What is the current behavior?

The repository lacks end-to-end (E2E) testing. This means there are no automated tests in place to validate the application's functionality from end to end. As a result, there is a higher risk of undetected bugs and it becomes challenging to ensure the overall reliability and robustness of the application.

Issue Number: #532

What is the new behavior?

Added setup files for end-to-end (E2E) testing using Playwright and Cucumber which facilitates Behavior-Driven Development (BDD) practices. With this setup, we can define test scenarios in Gherkin language, ensuring comprehensive coverage of our application's behavior.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ishabaral
Copy link
Author

Hi @treoden, I've added the setup files for E2E tests. Please review them, so that I can continue adding the automated test scripts.

@treoden
Copy link
Collaborator

treoden commented May 17, 2024

Hi @ishabaral ,

Yes I see. Please give me sometime I will get back to you asap
Thanks

tests/package.json Outdated Show resolved Hide resolved
tests/package.json Outdated Show resolved Hide resolved
tests/cucumber.conf.js Outdated Show resolved Hide resolved
tests/cucumber.conf.js Outdated Show resolved Hide resolved
tests/cucumber.conf.js Outdated Show resolved Hide resolved
tests/package.json Outdated Show resolved Hide resolved
tests/package.json Outdated Show resolved Hide resolved
@saw-jan
Copy link

saw-jan commented May 17, 2024

Also, another thought, should the e2e tests be in the project root or in the packages/evershop package?

added dotenv files

used variables from .env

set slowmo time to 0

cucumber config file edited
@ishabaral
Copy link
Author

Also, another thought, should the e2e tests be in the project root or in the packages/evershop package?

@treoden

@treoden
Copy link
Collaborator

treoden commented May 23, 2024

Hi @ishabaral , @saw-jan ,

I prefer the e2e be in the project root, not a part of evershop packages. Since it is for the core development only.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants