Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/2507 dependent dropdowns #2511

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Fix/2507 dependent dropdowns #2511

merged 4 commits into from
Sep 18, 2024

Conversation

kwongz
Copy link
Contributor

@kwongz kwongz commented Sep 6, 2024

Description

Fixes #2507

Fixes dropdown selection not updating when the filtered list changes. Previously, selected items would remain even if the filtered list became empty. Dropdown now updates selections based on available data.

Screen.Recording.2024-09-06.152709.mp4

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:13pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:13pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1fa7891

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@evidence-dev/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 1fa7891
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/66eb30b588866400087e972c
😎 Deploy Preview https://deploy-preview-2511--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit 1fa7891
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/66eb30b57bd3d40008f4ac15
😎 Deploy Preview https://deploy-preview-2511--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 1fa7891
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/66eb30b529aa0500087f85e0
😎 Deploy Preview https://deploy-preview-2511--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ItsMeBrianD
ItsMeBrianD approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ItsMeBrianD ItsMeBrianD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@zachstence zachstence merged commit 3ad3576 into next Sep 18, 2024
15 of 17 checks passed
@zachstence zachstence deleted the fix/2507-dependent-dropdowns branch September 18, 2024 20:10
@zachstence
Copy link
Member

Just noticed that this PR has caused a regression. Dropdowns no longer select the first option automatically.

For example: https://www.chromatic.com/test?appId=645d58d2e049d64800e0ee15&id=66eb3164c2b55e6f7a8c8026
The baseline shows "All" as its the first option and selected automatically
The new build shows "Test" which is the name of the Dropdown

There are several other Dropdown stories with the same kind of difference

I'm going to revert this PR and we can revisit

Should be easier to prevent future regressions with Chromatic (nearly) all cleaned up over here: #2436

@zachstence zachstence restored the fix/2507-dependent-dropdowns branch September 19, 2024 21:03
zachstence added a commit that referenced this pull request Sep 19, 2024
@zachstence
Revert "Merge pull request #2511 from evidence-dev/fix/2507-dependent…
e53ddbd 
…-dropdowns"

This reverts commit 3ad3576, reversing
changes made to 3914640.
@zachstence zachstence mentioned this pull request Sep 19, 2024
Merged
zachstence added a commit that referenced this pull request Sep 19, 2024
@zachstence
Revert "Merge pull request #2511 from evidence-dev/fix/2507-dependent…
6e4eced 
…-dropdowns"

This reverts commit 3ad3576, reversing
changes made to 3914640.
zachstence added a commit that referenced this pull request Sep 19, 2024
@zachstence
Merge pull request #2559 from evidence-dev/revert/fix/2507-dependent-…
951a7aa 
…dropdowns

Revert #2511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsMeBrianD ItsMeBrianD ItsMeBrianD approved these changes

@zachstence zachstence zachstence approved these changes

@archiewood archiewood Awaiting requested review from archiewood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown selections are not removed when the query changes to exclude them
3 participants
@kwongz @zachstence @ItsMeBrianD