Fix friend request messages not always being logged #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinlinden
force-pushed
the
log-freq-messages
branch
from
725fe30 to
338e544
Compare
iphydf
approved these changes
Dec 10, 2024
They were missing if you accepted a friend request from the long-press menu on a friend request in the contact list. This commit moves the logic for adding it down one layer, so now it can't be missed unless you skip over abstractions.
robinlinden
force-pushed
the
log-freq-messages
branch
from
338e544 to
235f9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were missing if you accepted a friend request from the long-press menu on a friend request in the contact list. This commit moves the logic for adding it down one layer, so now it can't be missed unless you skip over abstractions.
This issue was reported by @Yegorsh in #1278