Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple entrypoints #25

Closed
3 tasks done
tatarianBarbarian opened this issue Sep 7, 2023 · 2 comments · Fixed by #36, #37 or #38
Closed
3 tasks done

Add support for multiple entrypoints #25

tatarianBarbarian opened this issue Sep 7, 2023 · 2 comments · Fixed by #36, #37 or #38
Assignees

Comments

@tatarianBarbarian
Copy link
Collaborator

tatarianBarbarian commented Sep 7, 2023

Now, the code works with a single entry point.

It's possible for code to have multiple of them, and we should check how to handle it the right way.
We may want to split navigation to avoid possible confusion, for example.

This task is for checking what can go wrong and fixing it.

@tatarianBarbarian tatarianBarbarian self-assigned this Sep 11, 2023
@tatarianBarbarian tatarianBarbarian added this to the Usable integration milestone Sep 11, 2023
@tatarianBarbarian tatarianBarbarian linked a pull request Sep 11, 2023 that will close this issue
@tatarianBarbarian
Copy link
Collaborator Author

tatarianBarbarian commented Sep 11, 2023

Navigation object should be changed if we want to use it with multiple entry points.

We will add a new field to the navigation object, type, which can be flat | modular.

For flat navigation there will be following structure:

{
  type: 'flat',
  items: [
    { title: '...', url: '...' }
  ]
}

For modular navigation structure will be following:

{
  type: 'modular',
  modules: [
    {
      moduleName: 'module1',
      items: [{ title: '...', url: '...' }]
    },
    {
      moduleName: 'module2',
      items: [{ title: '...', url: '...' }]
    }
  ]
}

@ai
Copy link
Member

ai commented Sep 11, 2023

I hope in Sidebar component we will be able to make this navigation flat.

For Logux we need to mix all components, but for Nano Stores it will be better to keep them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment