Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit navigation format #36

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

tatarianBarbarian
Copy link
Collaborator

@tatarianBarbarian tatarianBarbarian commented Sep 11, 2023

This one changes navigation format to new one that described in #25 (comment)

Added new test environment -- project with multiple entry points.

Also changed templates.
Now navigation looks the same as before for single entry point, but for multiple entries it looks like this:

image

@tatarianBarbarian tatarianBarbarian changed the title WIP Create test environment with multiple entry points WIP Add support for multiple entrypoints Sep 11, 2023
@tatarianBarbarian tatarianBarbarian linked an issue Sep 11, 2023 that may be closed by this pull request
3 tasks
@tatarianBarbarian tatarianBarbarian self-assigned this Sep 11, 2023
@tatarianBarbarian tatarianBarbarian added this to the Usable integration milestone Sep 11, 2023
@tatarianBarbarian tatarianBarbarian changed the title WIP Add support for multiple entrypoints Edit navigation format Sep 11, 2023
@tatarianBarbarian tatarianBarbarian marked this pull request as ready for review September 11, 2023 17:55
@tatarianBarbarian
Copy link
Collaborator Author

To make it a bit more clear: Nanostores has one entry point which accumulates other index.d.ts from file like map, atom, etc.

I set up new environment by picking some of them from these folders, not from the root index.d.ts.

@tatarianBarbarian
Copy link
Collaborator Author

There is also new problem related to Astro and TypeDoc -- if project for documentation is on upper level, then TypeDoc generates it's name with _ symbol. So we getting following structure:

image

Which is not working for Astro. It works only with folders without any underscores for pages.
Will fix it with another PR.

@ai
Copy link
Member

ai commented Sep 11, 2023

To make it a bit more clear: Nanostores has one entry point which accumulates other index.d.ts from file like map, atom, etc.

For Nano Stores we will need to use index.d.ts from nanostores, @nanostores/router, etc. Can we add it to the test (to be sure that atom from nanostores and atom from @nanostores/router will be the same?

@tatarianBarbarian
Copy link
Collaborator Author

Sure, I'll add it then.

@tatarianBarbarian tatarianBarbarian merged commit 4e6187e into main Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple entrypoints
2 participants