Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMD module support for browser version #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add AMD module support for browser version #205

wants to merge 1 commit into from

Conversation

npbee
Copy link

@npbee npbee commented Jul 25, 2014

Hello! I'm using this library on the client-side only with RequireJS. I've added support to be able to load it as an anonymous AMD module.

If using a client-side js module loader like RequireJS this will allow the
markdjown-js library to be used with it rather than being shimmed.
@lexaux
Copy link

lexaux commented Jan 24, 2016

Hey @npbee and @evilstreak, some time has passed since then - I can see this being not merged in. At the same time the CI build seems to have failed independently of this very change AFAIU. Probably worth revisiting probability of merging this one in, wdyt?

@npbee
Copy link
Author

npbee commented Jan 24, 2016

Yikes, yes it's been a while. I think we can safely close this PR without merging. There looks to be an existing AMD solution here already which I think I just missed at the time. I apologize for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants