Enable the classic linker for macOS builds #623
Closed
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
macho-bcsave-fix
branch
4 times, most recently
from
f476a34 to
86cfcc2
Compare
The rewritten one seems to mess up the generated object files. Since I've no way of testing M1 builds, let's just see if it fixes the failures or if reverting is in order.
rdw-software
force-pushed
the
macho-bcsave-fix
branch
2 times, most recently
from
3b83a5d to
98d50db
Compare
Update BuildTarget.lua Update BuildTarget.lua Update BuildTarget.lua Update BuildTarget.lua Update NinjaBuildTools.lua Update ci-mac.yml Update ci-mac.yml Update BuildTarget.lua Update ci-mac.yml Update NinjaBuildTools.lua
This reverts commit 0a730e1.
This reverts commit c71a850.
This reverts commit d743805.
rdw-software
force-pushed
the
macho-bcsave-fix
branch
from
98d50db to
58ea814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewritten one seems to mess up the generated object files (see LuaJIT issues, there's several recent ones related to M1). Since I've no way of testing this, let's just see if it fixes the build failures or if reverting is in order.