-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset viewer CSS is affecting the SVGs themselves #158
Comments
Hi. Is there any intention to address this? I'm experiencing the same thing and it's certainly decreasing the usefulness of the svg viewer. Very much like the idea of this but this is quite the pain. I'm happy to knock out a PR if the maintainer has some thoughts on how they would like it fixed. |
Hi! I'm also seeing this same issue. Anyway I can help? |
Opened a PR to fix this in the dependency project, will also need to be bumped in package.json in this project. |
Ping @ivanvotti |
Does anyone know how the viewer is built? I could add the fix that I found here (thanks @marcemira!) but by looking at the last contributions being done 4 years ago and the fact that I don't see In this repo, I only found the minified CSS file but I guess we don't want to edit that 🤷♂️ As you can see, the fix works well: But how to propagate/apply it? 🤔 |
🐞 Bug Report
Describe the bug
There is some CSS in the asset viewer itself which is affecting the view of the SVGs in the viewer. Specifically, the fill is being overridden by the currentColor property. This specific class in the general.scss file in the asset viewer is causing the issue: https://github.com/ivanvotti/asset-viewer/blob/1b6e09bc6477ab0fc6295421acd70c667ea696cf/src/styles/base/general.scss#L24
Reproduce the bug
The following SVG will have the incorrect fill in the SVG viewer:
Expected behavior
The asset viewer shouldn't have CSS that affects the look of the SVGs within the viewer.
Possible Solution
Just fix the general.scss file to specific exactly which SVGs it wants to override the fill for. If I remove that line, the SVG looks as expected.
Screenshots
Image
![image](https://user-images.githubusercontent.com/2375555/80316806-ba703400-87b4-11ea-95db-a8beb901cbd2.png)
Devtools
![image](https://user-images.githubusercontent.com/2375555/80316840-04f1b080-87b5-11ea-98cf-2ed5bbe39256.png)
Additional context
The text was updated successfully, but these errors were encountered: